I see the code is trying to do some reallocating to grow the memory space as needed. I need to investigate further. Symptoms suggest we are not controlling the memory beyond 1000 bytes for some reason...
From: Gavin Remaley/SEL To: discuss@openvswitch.org Date: 07/13/2016 01:31 PM Subject: Meter config memory allocation problem We are using OVS v2.4.0 and seem to have discovered a memory allocation issue. When we have more than 41 meters (each with a single Band) defined, we regularly get corruption in meters 42 and beyond within a Meter Configuration Response to a request with meter_id=ALL. ofpmp_init() is used as part of the message handling in ofproto.c (handle_meter_request). It calls ofpraw_alloc_stats_reply, allocating 1000 "tail" bytes. Since each Meter requires 24 bytes in the message and 24 * 41 = 984, this seems to be the issue we are encountering. It looks like Meters 42 and beyond occupy memory that we do not own. Is this function being used properly with a Meter Configuration request? Why the hard-coded 1000 bytes of space? We need to fix this ASAP. We can do so, but an official patch would be better. Thanks.
_______________________________________________ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss
