Hi, Thanks for the update...
On Sat, 2022-04-23 at 10:28 -0700, Dave Fisher wrote: > Hi Sander, > > I’ve updated the Buildstream status: > - https://petri.apache.org/buildstream > - https://petri.apache.org/info.yaml > > I reviewed the repository and I’m not sure if I can check the source > header box. > > (1) Copyright statements remain. (I would accept that this will > change once BuildStream is a TLP) I wasn't aware we we're supposed to remove personal/corporate copyright statements from files, do I understand correctly that we should remove these from source files ? > (2) Should files like: master/src/buildstream/data/projectconfig.yaml > have an ASF Header? Likely yes. This file contains default project configuration data (not code), we have explicitly preferred to never include copyright/license headings to such files because we render these files verbatim into the documentation, which is very convenient and reliable, e.g.: https://docs.buildstream.build/master/format_project.html#builtin-defaults Our rationale so far for such yaml files has been that adding license/formal disclaimers/copyright statements etc to the heading of such files would detract from the readability of the documentation, and as they are just configuration data, we would prefer to leave these clean. Will it be acceptable to continue to leave these configuration files without license related headings ? > Has anyone run a RAT check? Is that what this java project is https://creadur.apache.org/rat/ ? No I have not tried to run this tool, I don't think anyone on the team has either as this is the first I'm hearing of it. Cheers, -Tristan
