Hi Piyush,

I agree again, CheckStyle will be a great addition. I've entered an issue
for it. I'll add support for it after beta 21.
http://restlet.tigris.org/issues/show_bug.cgi?id=194

Good point for PipeStream. Here is an area of improvement for FindBugs :)

Best regards,
Jerome  

> -----Message d'origine-----
> De : Piyush Purang [mailto:[EMAIL PROTECTED] 
> Envoyé : lundi 13 novembre 2006 12:36
> À : [email protected]
> Objet : findbugs and checkstyle
> 
> Hi Jerome,
> 
> It seems like you are already implementing the suggestions..
> Encodings.java etc. cool :)
> 
> But I think checkstyle should be preferred for revelations like using
> final while declaring constants etc.
> 
> What do you think?
> 
> Cheers
> Piyush
> 
> P.S: I saw that in PipeStream you did queue.put(Integer.valueOf(b));
> now wouldn't the auto(un)boxing take care of that?

Reply via email to