Friday, November 17, 2006, 11:48:26 AM, you wrote:

CG> Hello discuss,

CG> Tag has 2 constructors, Tag(String) and Tag(String, boolean).
CG> They're inconsistent this patch makes them consistent.
CG> Jerome, not sure if your intent was to have the quote checking or not.
CG> The single arg did, the double arg didn't.

CG> Personally I much prefer not having to quote all my tags and instead
CG> have the Tag class do that, so that's what the patch does.

I'm on a role, replying to myself today ;-)
I see now why you did this, because the headers you read from the
client are quoted. I still think it's confusing for someone creating
them in their restlets.

What would you think of a Tag.withQuotesRemoved(String name).
HttpRequest, HttpClientCall would use this to strip the quotes and
restlet writers would use the normal constructors?

If you like the idea I can send a patch.

Thanks,
Chris
-- 
Chris Grindstaff | http://gstaff.org

Reply via email to