Re: Possible null pointer in org.restlet.Server?

[Thierry Boileau]

Hello Mike,

good points!
 - I've just tagged the 1.0.4 release...
 - good remark indeed. Jérôme, do you agree?

best regards,
Thierry Boileau

I noticed this in passing:

@Override
    public void start() throws Exception {
        super.start();
        if (getHelper() != null)
            getHelper().start();
    }

@Override
    public void stop() throws Exception {
        getHelper().stop();
        if (getHelper() != null)
            super.stop();
    }

Given how start() is defined, it would seem stop() should have protection around the getHelper().stop() call i.e:

@Override
    public void stop() throws Exception {
        if (getHelper() != null)
            getHelper().stop();
        super.stop();
    }

Btw, I couldn't find the tag for 1.0.4; the latest I could find is 1.0.3: http://restlet.tigris.org/source/browse/restlet/tags/1.0/1.0.3/modules/org.restlet/src/org/restlet/Server.java?rev=2070&view=markup

Ta!