Thank you for including this!
I think with this addition to NRE, Restlet covers everything needed quite well for DAV 1; our implementation thereof is now functioning nicely. Restlet already includes all the relevant Status and Method definitions. I added RFE #346 per your suggestion; the only thing uglifying our DAV 1 port at present is the need for access to certain headers declared in the RFCs. If we encounter more items that would be helpful in cleanly implementing DAV Level 2, DeltaV, or Subversion compatibility, I'll file a new RFE for the relevant layer. - Rob ----- Original Message ----- From: "Jerome Louvel" <[EMAIL PROTECTED]> To: discuss@restlet.tigris.org Sent: Tuesday, August 14, 2007 5:26:11 PM (GMT-0500) America/New_York Subject: RE: Proposed OPTIONS compliance patch Hi Rob, Thanks for suggestion, I've just implemented it in SVN (1.0 and trunk). I think it would be interesting to open a RFE in the issues list to cover all the features that are required/helpful to implement WebDAV clients and servers. The goal would not be to provide such applications which are out of the Restlet API and NRE scope. Best regards, Jerome > -----Message d'origine----- > De : Rob Heittman [mailto:[EMAIL PROTECTED] > Envoyé : mardi 14 août 2007 20:35 > À : discuss@restlet.tigris.org > Objet : Proposed OPTIONS compliance patch > > > Hello, > > We've been greatly enjoying migrating our WCM and commerce platform > to the Restlet API. We have a versioned filesystem historically > exposed via a WebDAV Servlet, which was reasonably > straightforward to > adapt to Restlet. > > One issue, however, seemed to require a patch to get past; the NRE > does not seem to respond in a compliant way to OPTIONS requests, > since the Allow: header is only included when > Status.CLIENT_ERROR_METHOD_NOT_ALLOWED. This causes trouble with > (the woefully rare) polite WebDAV clients that actually ask for > allowed methods prior to attempting to use them. Since OPTIONS is > part of the HTTP/1.1 specification and not just DAV specific, > I think > support for this seems reasonable in core NRE. > > I've had success with the following patch to > com.noelios.restlet.http.HttpServerConverter.java -- any chance of > committing it? Happy to open an issue for it if you concur it's > worthwhile. I imagine other converters might need similar surgery, > but we're only using the HttpServerConverter right now, so > this is my > first priority! > > In related matters ... I saw mention in the blog that full WebDAV > exposure is on the roadmap; if you need more resources to > assist with > this, my team and I would be pleased to help; we have a lot of > practical experience coping with the behavior and misbehavior of the > myriad DAV user-agents out there. > > Cheers, > > - Rob > > > Index: . > =================================================================== > --- . (revision 2129) > +++ . (working copy) > @@ -129,7 +129,9 @@ > .getResponseHeaders(); > > if (response.getStatus().equals( > - Status.CLIENT_ERROR_METHOD_NOT_ALLOWED)) { > + Status.CLIENT_ERROR_METHOD_NOT_ALLOWED) || > + response.getRequest().getMethod().equals( > + Method.OPTIONS)) { > // Format the "Allow" header > StringBuilder sb = new StringBuilder(); > boolean first = true;
