Hello,

well, I'm afraid that I'm the author of the change...
Let's see with Jérôme if we keep the "equalsIgnorCase" test or not.

best regards,
Thierry Boileau

> Hello Bruno, Bruce,
>
> well that's weird, the current 2.0 release (in the svn repository) uses 
> "equalsIgnoreCase" not "equals". And I was not aware this had changed.
>
>
> best regards,
> Thierry Boileau
>   
>> Hi Bruce/Thierry,
>>
>> It seems that the code has changed between version 1.1 and 2.0.
>>
>> In 1.1.5, com.noelios.restlet.application.TunnelFilter uses 
>> 'equalsIgnoreCase' (line 388), whereas in the trunk (2.0), 
>> org.restlet.engine.application.TunnelFilter uses 'equals' (line 528).
>>
>> I think it makes sense to use 'equals' instead of 'equalsIgnoreCase' 
>> (although I'm not sure which one is best), but the accept.properties 
>> files should probably be updated to reflect this change (the version in 
>> the trunk still uses lower case for all agent names).
>>
>> Best wishes,
>>
>> Bruno.
>>
>> Bruce Cooper wrote:
>>   
>>     
>>> Hi guys,
>>>
>>> I have found that the agentName is reporting as Safari with a capitol S 
>>> whereas the standard file has it listed with a lowercase s, so I've 
>>> needed to add a separate rule in accept.properties.  Because I want to 
>>> only override the default Accept that is being sent through (and so that 
>>> I can put in other accepts in XMLHttpRequest requests and not have them 
>>> overridden)//, I think it is best to include the acceptOld as shown below://
>>>
>>> #Safari
>>> agentName: Safari
>>> acceptOld: 
>>> application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
>>> acceptNew: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
>>>
>>> This appears to work for me, so I'm happy.  Let me know if you think it 
>>> is a good solution.
>>>
>>> Bruce.
>>>     
>>>       
>> ------------------------------------------------------
>> http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=2365378
>>
>>
>>     
>
> ------------------------------------------------------
> http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=2365482
>
>

------------------------------------------------------
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=2365596

Reply via email to