[pfSense-discussion] Re: Re: Feature Idea/Request - Comments for entries in Host/Network Aliases

[Joshua Coombs]

Ok, I'm making progress.  This will allow you to add/edit descriptions 
for existing alias entries.  I've not quite wrapped my head around the 
row helper javascript, so when you add en entry, the details field is 
not included.  Just add the entries, go back, and fill in the details 
as a second edit for now.

Joshua Coombs
--- firewall_aliases_edit.php   Wed Dec 28 11:00:34 2005
+++ firewall_aliases_edit.jc    Thu Dec 29 10:07:49 2005
@@ -62,6 +62,11 @@
                       $pconfig['type'] = "port";

       $pconfig['descr'] = $a_aliases[$id]['descr'];
+       $address_details = explode('|', $a_aliases[$id]['detail']);
+       if (is_array($address_details))
+               $address_detail = $address_details[0];
+       else
+               $address_detail = $address_details;
}

if ($_POST) {
@@ -125,6 +130,7 @@

               $address = $alias['address'];
               $isfirst = 0;
+
               for($x=0; $x<99; $x++) {
                       $comd = "\$subnet = \$_POST['address" . $x . 
"'];";
                       eval($comd);
@@ -137,7 +143,19 @@
                       }
               }

+
+                $final_address_details .= $_POST['detail'];
+               $final_address_details .= "|";
+               for ($x=2; $x<99; $x++) {
+                       $comd = "\$final_address_detail = 
\$_POST['detail" . $x . "'];";
+                       eval($comd);
+                        $final_address_details .= 
$final_address_detail;
+                       $final_address_details .= "|";
+               }
+
+
               $alias['address'] = $address;
+                $alias['detail'] = $final_address_details;
               $alias['descr'] = $_POST['descr'];

               if (isset($id) && $a_aliases[$id])
@@ -295,7 +313,9 @@
                       <?php
                       $counter = 0;
                       $address = $a_aliases[$id]['address'];
+                       $address_detail = $a_aliases[$id]['detail'];
                       $item = explode(" ", $address);
+                       $item3 = explode("|", $address_detail);
                       foreach($item as $ww) {
                               $address = $item[$counter];
                               $address_subnet = "";
@@ -306,6 +326,7 @@
                                               $address_subnet = 
$item2[1];
                                       }
                               }
+                               $item4 = $item3[$counter];
                               if($counter > 0) $tracker = $counter + 
1;
                       ?>
                       <tr><td> <input name="address<?php echo 
$tracker; ?>" type="text" class="formfld" id="address<?php echo 
$tracker; ?>" size="20" 
value="<?=htmlspecialchars($address);?>"></td><td>
@@ -315,6 +336,7 @@
                         <option value="<?=$i;?>" <?php if ($i == 
$address_subnet) echo "selected"; ?>><?=$i;?></option>
                         <?php endfor; ?>
                       </select>
+                       </td><td> <input name="detail<?php echo 
$tracker; ?>" type="text" class="formfld" id="detail<?php echo 
$tracker; ?>" size="50" 
value="<?=htmlspecialchars($item4);?>"></td><td>
                         <?php
                               if($counter > 0)
                                       echo "<input type=\"image\" 
src=\"/themes/".$g['theme']."/images/icons/icon_x.gif\" 
onclick=\"removeRow(this); return false;\" value=\"Delete\">";