I use the "load balancer pool edit" page quite a lot, adding and removing servers from my active pool. It gets kind of old typing the IPs when re-adding servers, and I understand it needs a little refinement anyway, so I propose some changes (which I am willing to code). The basic idea is to have pfSense keep in the load balancer pool configuration two types of servers (enabled and disabled) and be able to quickly change the servers from "enabled" to "disabled" and vice versa. I think this can be accomplished pretty easily, and I have a decent idea of how to do it, having sorted through the code a little, but I just want to make sure before I spend any real time on it. A mockup of how the relevant portion of the interface would look (note the reordering buttons that are mentioned on CVS Trac, for reordering the list for a failover pool; I will do this also): http://www.gliffy.com/publish/1251841/

As for the config end of it, the servers' IP addresses are currently stored as multiple entries that look like: "<servers>ip.add.re.ss</servers>" -- in my changes, the addition would be entries that look like "<serversdisabled>ip.add.re.ss</serversdisabled>" (for saving the "disabled" list). I didn't see any facility for parsing tag attributes ... please let me know if this is there somewhere and I'll make it more like '<servers enabled="true">...' or so. It looks like pfSense will just ignore the "disabled" entries when reading the configuration for applying without any changes to filter.inc ... please let me know if I'm missing anything here.

It all seems pretty straightforward and simple. Please let me know if I'm missing anything. This is my first attempt at contributing to pfsense; would these changes be useful to anyone other than me? Also, which branch should I make patches for, etc., if so? Thanks in advance.

--
Chris Daniel

Reply via email to