Sorry for the delay - can you submit a patch for this? Thanks,
Matt > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Damm, Gary > Sent: Wednesday, April 16, 2003 11:05 AM > To: Damm, Gary; [EMAIL PROTECTED] > Subject: [displaytag-devel] RE: PageNumber/Sorting quirk... > > > I've fixed this problem locally by adding the page parameter > to the column sort URL's in TableTag.getTableHeader(). Any > interest in making this change to the library itself? > > Here is the change: > > >From (TableTag.java line 1482): > ... > if( tag.getSort() != null ) { > if( this.sortOrder == SORT_ORDER_ASCEENDING ) { > buf.append( "<a href=\"" + url + > "?order=dec&sort=" + i + "\" class=\"tableCellHeader\">" ); > } else { > buf.append( "<a href=\"" + url + > "?order=asc&sort=" + i + "\" class=\"tableCellHeader\">" ); > } > buf.append( header ); > buf.append( "</a>" ); > } > ... > > To: > ... > if( tag.getSort() != null ) { > if( this.sortOrder == SORT_ORDER_ASCEENDING ) { > buf.append( "<a href=\"" + url + > "?order=dec&sort=" + i + "&page=" + this.pageNumber + "\" > class=\"tableCellHeader\">" ); > } else { > buf.append( "<a href=\"" + url + > "?order=asc&sort=" + i + "&page=" + this.pageNumber + "\" > class=\"tableCellHeader\">" ); > } > buf.append( header ); > buf.append( "</a>" ); > } > ... > > Gary > > -----Original Message----- > From: Damm, Gary > Sent: Monday, April 14, 2003 11:13 AM > To: '[EMAIL PROTECTED]' > Subject: PageNumber/Sorting quirk... > > I've noticed something when combining paging and sorting.� If > you are on page 3 and click on sortable column 1 on Tomcat > you are sent to sorted column 1 on page 3 (this is what I'd > expect).� While doing the same action on WebSphere you are > sent back to page 1 when clicking on sortable column 1 of page 3. > � > After some investigation it actually appears that Tomcat is > holding the instance variable in an instance of the TableTag.� > But this is not something that can be depended upon > (obviously not on WebSphere).� Nor would you want to since > this could cause session issues.� > � > Is there some reason that the sorting request parameters do > not include page so I am consistently sent back to the > appropriate page?� Or am I missing something?� Does 0.8.5 fix this? > � > Env Details: > Display Tag 0.8 > Tomcat 4.1 > WebSphere 4.0 > Struts 1.1 b3 > � > Thanks, > Gary > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > displaytag-devel mailing list [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/displaytag-devel > ------------------------------------------------------- This SF.NET email is sponsored by: eBay Great deals on office technology -- on eBay now! Click here: http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
