I think a property to define the sorting behavior is a good idea, but if
you use other custom tags to define the content of the column the only
way to sort is to parse the content as a String, which is pretty slow
and dirty...
I should admit that, for this task, the decorator approach works a lot
better, that was the first reason why I thought to mantains decorators
and compatibility with 0.8.5 version.

How does your sorting property work, John? (I'll try to look at your
code). Is it similar to the decorator approach?

About the exporting function, I also implemented a two steps export that
can be used when you are not able to clear the response (note the
standard beaviour of an app server should be to do a flush after each
custom tags, so you should have this problem every time you put a single
tag before the <display> tag). In this way you first have a preview
("generated file: 1.234 bytes, click here to save") and exporting goes
directly through a servlet. This is not in the source code I submitted
to the cvs server but in a separate module I build to adapt the table
tag for work in Websphere portal server (maybe we can add that as a
separate release in future? I don't know how many people could use WPS,
but maybe someone could find it useful...)

these were my 2 cents, other opinions on sorting and export?

fabrizio




-----Original Message-----
From: John York [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, June 17, 2003 5:46 PM
To: Fabrizio Giustina
Cc: Andrew Lapanik; [EMAIL PROTECTED]
Subject: RE: [displaytag-devel] Column body


I would think that the column body would override the existing behavior.


I still think property needs to be set for those cases when you're
sorting a 
column that may contain html in it, you don't want to sort based on
things 
you can't see in the browser, so my implementation uses property to sort

on in this case. Also, for exporting to CSV/Excel/XML, I don't think you

would ever want to show the html, so I just use the property for that
too. This 
was another one of my original reasons for refactoring, so I spent alot
of 
time getting it to work that way.

Any other opinions on this one?


On Tue, 17 Jun 2003, Fabrizio Giustina wrote:

> the body in columntag is used for showing column if no "property" 
> attribute is specified. If the property attribute is added everything 
> works as in the original version
>  
> fabrizio
>  


-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner.
Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
_______________________________________________
displaytag-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to