Bugs item #823383, was opened at 2003-10-14 14:04 Message generated for change (Comment added) made by fgiust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=536613&aid=823383&group_id=73068
Category: main tag library Group: v 1.0-b1 >Status: Closed Resolution: None Priority: 5 Submitted By: Paul McCulloch (paulmcculloch) Assigned to: fabrizio giustina (fgiust) Summary: Body not cleared with pooled ColumnTags Initial Comment: There seems to be a bug in the way the column tag is validating. It should throw an exception if there is neither a property, a value or some body content in the tag. However, this doesn't always work: <display:column title="Col 1" sortable="true"> XXXXXX </display:column> <display:column title="Col 2" sortable="true"/> Doesn't produce an error. This is because the result of getBodyContent() in ColumnTag.java::doEndTag() is "XXXXXX", rather than null for the second column (due to tag pooling I assume). It's unclear to me whether this is the responsibility of the container (Tomcat 4.1.18) or the tag itself. setBodyContent(null); at the end of doEndTag() fixes things - but I'm not sure if it's neccessary. Although this isn't much of an issue iby itself, I'm working on an enhancement which would allow the specification of a property & a body (display the body, sort by the property) where this is an issue - I'd appreciate an opinion on whether this is a container or tag issue. (v1.0-b1, Tomcat 4.1.18, JDK 1.4.1_04) ---------------------------------------------------------------------- >Comment By: fabrizio giustina (fgiust) Date: 2003-10-21 22:18 Message: Logged In: YES user_id=798060 added the setBodyContent(null) in ColumnTag (rel 1.0-b2) ---------------------------------------------------------------------- Comment By: Paul McCulloch (paulmcculloch) Date: 2003-10-16 12:18 Message: Logged In: YES user_id=883626 I think this is due to the way tag handler reuse is implemented by Tomcat. My understanding is that a handler instance will be reused between 'calls' only when the attributes specified match. So <display:column> XXXXXX </display:column> <display:column/> Will also show the bug (I think - I can't easilly test that now as I'm running a patched version of the taglib). ---------------------------------------------------------------------- Comment By: fabrizio giustina (fgiust) Date: 2003-10-16 00:04 Message: Logged In: YES user_id=798060 I can reproduce this with tomcat 4.1.24 It seems this happens only when specifying the "sortable" attribute in both columns (?) Need to investigate a little more on the causes... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=536613&aid=823383&group_id=73068 ------------------------------------------------------- This SF.net email is sponsored by OSDN developer relations Here's your chance to show off your extensive product knowledge We want to know what you know. Tell us and you have a chance to win $100 http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54 _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
