I prefer John's way of doing things - it is better able to reuse existing
custom tags to format the data.

I've proposed a very simple change which would allow pretty much what John
is suggesting, other than explicitly exposing the current column's value.
e.g.

<display:column property="mydate">
  <display:format type="date" arg="YYYY-MM-DD">
    <bean:write name="${currentrow.mydate}"/>
  </display:format>
</display:column>  

I'd be grateful for comments on my proposal: 
http://sourceforge.net/tracker/index.php?func=detail&aid=823393&group_id=730
68&atid=536616

Paul

-----Original Message-----
From: John York [mailto:[EMAIL PROTECTED]
Sent: 05 November 2003 13:57
To: [EMAIL PROTECTED]
Subject: Re: [displaytag-devel] [ displaytag-Feature Requests-683989 ]
<display:column format="dd-MMM-yyyy"> needed for date propt


I don't think that this feature should be part of the core displaytag. 
This is where the various string formatting utilities come into play. I'd 
envision something like this:

<display:column property="mydate">
  <display:format type="date" arg="YYYY-MM-DD">
    <bean:write name="mydate"/>
  </display:format>
</display:column>  


On Tue, 4 Nov 2003, SourceForge.net wrote:

> Feature Requests item #683989, was opened at 2003-02-10 17:19
> Message generated for change (Comment added) made by ravn
> You can respond by visiting: 
>
https://sourceforge.net/tracker/?func=detail&atid=536616&aid=683989&group_id
=73068
> 
> Category: None
> Group: None
> Status: Open
> Resolution: None
> Priority: 5
> Submitted By: Thorbjoern Ravn Andersen (ravn)
> Assigned to: Nobody/Anonymous (nobody)
> Summary: <display:column format="dd-MMM-yyyy"> needed for date propt
> 
> Initial Comment:
> We have a need for providing a formatstring for dates
> as the default is not good enough.
> 
> I have a patch, which I am testing out.  If there is
> interest I can upload it.
> 
> ----------------------------------------------------------------------
> 
> Comment By: Thorbjoern Ravn Andersen (ravn)
> Date: 2003-11-04 21:32
> 
> Message:
> Logged In: YES 
> user_id=14845
> 
> Have you timed this?  My experiments with this approach 
> showed a substantional slowdown as noted earlier.
> 
> ----------------------------------------------------------------------
> 
> Comment By: Tim Golden (luckynh)
> Date: 2003-10-27 22:34
> 
> Message:
> Logged In: YES 
> user_id=704330
> 
> use a custom decorator:
> 
> /*
>  * <p>Simple Date Format</p>
>  * @author luckynh
>  * @version 1.0 $Revision: .0 $ ($Author: luckynh $)
>  */
>  use a custom decorator:
> 
> import java.text.SimpleDateFormat;
> import java.util.Date;
> import org.apache.taglibs.display.ColumnDecorator;
> 
> public class ShortDateWrapper extends ColumnDecorator
> {
>      private SimpleDateFormat sdf = new SimpleDateFormat(
> "MM/dd/yyyy" );
>      
>       public String decorate( Object columnValue )
>           {
>           Date t = (Date)columnValue;
>           return sdf.format( t );
>      }
> }
> 
> 
> ----------------------------------------------------------------------
> 
> Comment By: Thorbjoern Ravn Andersen (ravn)
> Date: 2003-08-11 14:38
> 
> Message:
> Logged In: YES 
> user_id=14845
> 
> I have now taken the time to merge the changes with the
> latest source from CVS, and submit patch 786617.
> 
> 
> ----------------------------------------------------------------------
> 
> Comment By: Thorbjoern Ravn Andersen (ravn)
> Date: 2003-08-07 13:37
> 
> Message:
> Logged In: YES 
> user_id=14845
> 
> I have now tried to upgrade my old source tree to be in
> synch with the SF CVS, but Eclipse has some problems with
> this.  When this is resolved, I will submit my patch which
> is in production use here.
> 
> ----------------------------------------------------------------------
> 
> Comment By: Thorbjoern Ravn Andersen (ravn)
> Date: 2003-03-13 22:11
> 
> Message:
> Logged In: YES 
> user_id=14845
> 
> I have found that the Wrapper system is noticably slower
> than just overriding the toString method.  Unfortunately, I
> cannot do this in our scenario (objects come from JDBC).
> 
> I hope to have time to prepare the patch this week.
> 
> 
> 
> ----------------------------------------------------------------------
> 
> Comment By: Didier Dubois (didier_dubois)
> Date: 2003-03-06 10:41
> 
> Message:
> Logged In: YES 
> user_id=726985
> 
> I resolved the problem doing the following step:
>  - using a patch similar to the one posted by scottnsmith. 
> This allow null Date comparison
>  - Using a bean returning a "Date" object (which is correctly 
> compared by Java)
>  - Using a DateWrapper for this column that returns the 
> formated Date as a String.
> 
> HTH.
> 
> ----------------------------------------------------------------------
> 
> Comment By: Didier Dubois (didier_dubois)
> Date: 2003-03-05 17:29
> 
> Message:
> Logged In: YES 
> user_id=726985
> 
> YES!
> 
> I have the same problem. But further more I need to sort my 
> table on this date. Do your pathc support this?
> 
> Didier
> 
> ----------------------------------------------------------------------
> 
> Comment By: Matt Raible (mraible)
> Date: 2003-02-14 14:51
> 
> Message:
> Logged In: YES 
> user_id=226669
> 
> I've subclassed Date and overridden the toString() method as 
> a workaround.  I agreet that adding a format attribute is 
> probably a better solution.  Please submit your patch.
> 
> ----------------------------------------------------------------------
> 
> You can respond by visiting: 
>
https://sourceforge.net/tracker/?func=detail&atid=536616&aid=683989&group_id
=73068
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive?  Does it
> help you create better code?   SHARE THE LOVE, and help us help
> YOU!  Click Here: http://sourceforge.net/donate/
> _______________________________________________
> displaytag-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/displaytag-devel
> 
> 

-- 
John York
Software Engineer
CareerSite Corporation



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
displaytag-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/displaytag-devel


**************************************
Axios Email Confidentiality Footer
Privileged/Confidential Information may be contained in this message. If you are not 
the addressee indicated in this message (or responsible for delivery of the message to 
such person), you may not copy or deliver this message to anyone. In such case, you 
should destroy this message, and notify us immediately. If you or your employer does 
not consent to Internet email messages of this kind, please advise us immediately. 
Opinions, conclusions and other information expressed in this message are not given or 
endorsed by my Company or employer unless otherwise indicated by an authorised 
representative independent of this message.
WARNING:
While Axios Systems Ltd takes steps to prevent computer viruses from being transmitted 
via electronic mail attachments we cannot guarantee that attachments do not contain 
computer virus code.  You are therefore strongly advised to undertake anti virus 
checks prior to accessing the attachment to this electronic mail.  Axios Systems Ltd 
grants no warranties regarding performance use or quality of any attachment and 
undertakes no liability for loss or damage howsoever caused.



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
displaytag-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to