I will add soon your patch to CVS, I added the export.filename property some time ago 
and never completed this feature...
Only a note, I would prefer leaving the extension in the filename and not add it as a 
property for the ExportView (so that the user can change it).
 
 
 
Fabrizio Giustina
 
>>> html in this mail is produced by outlook web access, no way to turn it off, sorry
 
 

From: [EMAIL PROTECTED] on behalf of Serge Knystautas
Sent: Wed 1/14/2004 01:50
To: [EMAIL PROTECTED]
Subject: Re: [displaytag-devel] export.filename



Attached is a patch file for the export.filename support.  With this,
you can add the following line to src/webapp/example-export.jsp, it sets
the filename for the download:

   <display:setProperty name="export.filename" value="exportfile" />

Hopefully the changes make sense.

--
Serge Knystautas
President
Lokitech >>> software . strategy . design >> http://www.lokitech.com
p. 301.656.5501
e. [EMAIL PROTECTED]

John York wrote:
> Hi Serge, if you'd like to write this feature, we can definitely
> incorporate it into our codebase. The best way to do this is provide us a
> patch for the files that you are changing and then we can take a look at
> it and merge it in. I believe sourceforge has more information about
> patching if you need it.
>
> John
>
>
> On Tue, 13 Jan 2004, Serge Knystautas wrote:
>
>
>>I've been following displaytags from a distant, and finally looking at
>>incorporating in some of our code.
>>
>>One feature that seems to be started that I would definitely need is to
>>set the download filename during an export.  This would require setting
>>the content disposition header in the response with the filename, not
>>too hard to do.
>>
>>I say this was started because there is an undocumented export.filename
>>property PROPERTY_STRING_EXPORT_FILENAME (export.filename) and
>>TableProperties.getExportFileName().  However, this is never called
>>during TableTag.writeExport(mimeType, exportString).
>>
>>Is there any interest in such a patch to complete this feature?  It
>>doesn't look like very much work.. just patches to TableTag and
>>ResponseOverrideFilter.  Anything I'm missing, and anything special
>>about how you like contributions?
>>
>>
>
>




<<winmail.dat>>

Reply via email to