I am looking forward to working with everyone! I just came from a job where we made all our own custom widgets with a custom framework. Now that I am now longer there it was great to find such a quality project where I can hopefully contribute something and have a great tag to use.
Have a good weekend!
-Jeff
John York wrote:
Ok, I understand now. This seems to be quite useful. How do you enable this feature? Is it an additional attribute in the <display:table> tag? We've added quite a few extensions this way, maybe we should consider adding a <display:options> tag or something similar to control all of our customizable features?
I still would like to create a bare-bones version of this tag that lets you completely specify the how the HTML should look. Then, you could customize where you wanted the filter row to show up. It probably does make the most sense up top, but I could definitely see people wanting to fine-tune it's exact position.
If you've got time and are interested in refactoring, I'd love to see a UML diagram and I think the other would welcome such work and be happy to integrate it. Currently, we're trying to finalize our latest release, so this would be good to add into the next version of the tag.
John
Jeff Johnston wrote:
>>I'm not quite sure I follow your filter idea
I think a picture is in order then...forgive the crude test data :). Ideally you would want to have droplist fields also, instead of just text input fields...maybe even checkboxes for yes/no type data. So, basically you just put in values for whatever columns you want to filter and then hit the filter button. To clear the fields and start over you press the clear button.
I agree with keeping the code lightweight. Its always easier to code and test if the classes are lightweight and specific to their task. This morning I made up a UML diagram for the project, and then tonight I will start to document the current flow so I am clear about how things work overall. I really have nothing else going on right now and I think refactoring code is fun so...
-Jeff
John York wrote:
I'm not quite sure I follow your filter idea. You're trying to selectively show or hide certain columns?
As for the refactoring, I originally had a version of this that was much better structured and for some reason we've decided to include all of the HTML support in TableTag.java. I've tried to convince people that we should pull all the HTML specific code out and properly create the view layer of our MVC structure. I would appreciate any work you do if you want to make a proposal to the list I'm sure the group will review it and decide whether to add it to the code base or not.
There are alot of different features that people like to add on top of this taglib, I've been pushing for a structure that would allow adding just the functionality you need and keeping this tag as lightweight as possible. Unfortunately, I'm in the middle of preparing for my wedding in June, so I haven't been able to find any time to start specing out this design.
John
Jeff Johnston wrote:
I just discovered Displaytag a few weeks ago. First of all I want to say I think you have a really great custom tag. We are now using it in our company and it is working great! It is very easy to use and very flexible. I have been looking at the code also and everything seems very solid
The only feature that was missing for us was the abiltiy to filter the display. So I spent some time and plugged filters in. If you can visual this, what I did was put nicely formatted input tags on a separate row that maps to each column. The filter and clear button are on the right side. I can send pictures if anyone wants to see what they look like. I'd love to send someone the code when I'm done, and if people are interested. It works pretty good now, but I am for sure not done yet.
Also, like I said the code looks very solid, but I can see some opportunities to refactor some of the code. The TableTag itself is over 1700 lines long, and from a new guy perspective I found it harder than it should have been to plug in this new feature. Although, once I figured it out you guys basically did all my work for me because I just used what you had :). I am not trying to step on anyones toes so do not take it that I am trying to say anthing negative about the project. At work we are going with your Displaytag and just want to help you add more to it, not just rip off your code and start from here. I looked through the posting and I saw some interest in refactoring the code and making it easier to plug features in, so what I am really asking is if people are still interested? I'd be willing to write up some proposals to get the ball rolling if this sounds good.
-Jeff
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
------------------------------------------------------------------------
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
