RE: [displaytag-devel] patch for BufferedResponseWrapper

[Dmitri . Colebatch]

Title: Message

yep - fine by me.  I did a small amount of research into why it wasn't done this way in the first place but didn't find anything.  I'm interested to hear the reason (its obviously been a conscious decision).

 

An alternative might be to have the response wrapper used be configurable at the filter level - providing for both cases.  If it comes back that there's a reason the current patch doesn't suit then I'll do that - marginally more complicated, but would keep us all happy.

 

cheers

dim

---

From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Matt Raible
Sent: Monday, 26 July 2004 5:27 PM
To: [EMAIL PROTECTED]
Subject: RE: [displaytag-devel] patch for BufferedResponseWrapper

Dmitri,

 

I can't apply this patch w/o getting the OK from Fabrizio - especially since the class explicity states

// don't extend j2ee 1.3 HttpServletResponseWrapper

And this is exactly what you do in your patch - unless I'm misunderstanding something. 

Fabrizio - what do you think?

Matt

-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED]
Sent: Sunday, July 25, 2004 7:29 PM
To: [EMAIL PROTECTED]
Subject: [displaytag-devel] patch for BufferedResponseWrapper

Refer to http://sourceforge.net/forum/forum.php?thread_id=1068117&forum_id=249318 for history.

 

As discussed, I've attached a simple patch that makes BufferedResponseWrapper extend HttpServletResponseWrapper instead of implementing ServletResponse directly.  I'm still not sure why this wasn't done like this in the first place, but it seems to work ok for me.

 

cheers

dim

 

 

#####################################################

DISCLAIMER:
This email and any attachment may contain confidential information.
If you are not the intended recipient you are not authorized to copy
or disclose all or any part of it without the prior written consent
of Toyota.

Opinions expressed in this email and any attachment are those of the
sender and not necessarily the opinions of Toyota.
Please scan this email and any attachment for viruses.
Toyota does not accept any responsibility for problems
caused by viruses, whether it is Toyota's fault or not.
#####################################################

#####################################################

DISCLAIMER:
This email and any attachment may contain confidential information.
If you are not the intended recipient you are not authorized to copy
or disclose all or any part of it without the prior written consent
of Toyota.

Opinions expressed in this email and any attachment are those of the
sender and not necessarily the opinions of Toyota.
Please scan this email and any attachment for viruses.
Toyota does not accept any responsibility for problems
caused by viruses, whether it is Toyota's fault or not.
#####################################################