Bugs item #1026408, was opened at 2004-09-11 20:35 Message generated for change (Comment added) made by ivan_markov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=536613&aid=1026408&group_id=73068
Category: main tag library Group: None Status: Open Resolution: None Priority: 3 Submitted By: Ivan Markov (ivan_markov) Assigned to: fabrizio giustina (fgiust) Summary: PDF Export & smart Paging Initial Comment: Hello guys, Please, find attached patch to DT (latest CVS of Sep 11 2004) that implements: - PDF export - Smart paging (implemented without parsing DT's request parameters). Detailed explanation is contained in the attached README.txt file. Regards, Ivan ---------------------------------------------------------------------- >Comment By: Ivan Markov (ivan_markov) Date: 2004-09-22 20:43 Message: Logged In: YES user_id=714267 Hi Fabrizio, - We've fixed all JUnit failures except 4 which are all related to a test checking if there are 3 export links on a page, whereas with our patch we have 4 (the 3 old ones + PDF). - We've separated the patch into two: a) PDF export only b) PDF export + smart paging The newly uploaded files are: a) dt_pdf.diff - diff to displaytag2 CVS surface from Sep 22, which implements the PDF export b) dt_pdf_paging.diff - diff to displaytag2 CVS surface from Sep 22, which implements the PDF export + smart paging Also, since the code in CVS seems to rapidly change, we've also included the whole Java sources for each of these patches: c) dt_pdf_java.zip d) dt_pdf_paging_java.zip ---------------------------------------------------------------------- Comment By: Ivan Markov (ivan_markov) Date: 2004-09-20 19:42 Message: Logged In: YES user_id=714267 Hi Fabricio, Sorry for the failed JUnit tests! We didn't run them before, bc we were not utilizing the Maven build for the project. Now that we have Maven up & running, all of these JUnit failures are fixed locally at our side. Actually, all of these except 4 were due to us having overlooked ELTableTag.setName() which should be changed a bit to work with our DataProvider stuff too (so the reason why most of the JUnit failures were with the JSTL EL TableTag). Anyways, tomorrow I'll submit 2 new patches with the fixed code; one for the PDF export (per your request) + another one for the PDF export + the smart paging stuff. Sorry for the inconvenience! ---------------------------------------------------------------------- Comment By: fabrizio giustina (fgiust) Date: 2004-09-18 14:53 Message: Logged In: YES user_id=798060 tested: current patch causes 34 unit tests to fail (4 failures, 30 errors). Please run junit tests before submitting a patch ---------------------------------------------------------------------- Comment By: fabrizio giustina (fgiust) Date: 2004-09-18 12:34 Message: Logged In: YES user_id=798060 thanks for the contributions, Ivan I already planned to make the export system extensible in a similar way (only using properties, without need to register a view using API), so your contribution is really welcome. Smart paging is probably more delicated, and I plan to add it only in the 1.1 branch of displaytag. I would be better to have separate patches for these two features, if possible. Could you upload separate patches for them? ---------------------------------------------------------------------- Comment By: Ralf Hauser (ralfhauser) Date: 2004-09-13 18:46 Message: Logged In: YES user_id=266141 see also http://sourceforge.net/tracker/index.php?func=detail&aid=951204&group_id=73068&atid=536616, http://sourceforge.net/tracker/index.php?func=detail&aid=869959&group_id=73068&atid=536616, http://sourceforge.net/tracker/index.php?func=detail&aid=1023387&group_id=73068&atid=536613, ---------------------------------------------------------------------- Comment By: Ivan Markov (ivan_markov) Date: 2004-09-11 20:41 Message: Logged In: YES user_id=714267 The zip archive only contains the Java files, bc I've hit the sf limit of 256K max upload size. ---------------------------------------------------------------------- Comment By: Ivan Markov (ivan_markov) Date: 2004-09-11 20:37 Message: Logged In: YES user_id=714267 Patched DT sources. ---------------------------------------------------------------------- Comment By: Ivan Markov (ivan_markov) Date: 2004-09-11 20:35 Message: Logged In: YES user_id=714267 Diff file uploaded. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=536613&aid=1026408&group_id=73068 ------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
