Message:

   The following issue has been resolved as FIXED.

   Resolver: fabrizio giustina
       Date: Mon, 11 Oct 2004 8:52 AM

Unfortunately there is no "standard way" to lookup a localization context set using 
the fmt:bundle tag.

I changed the jstl adapter to also look for bundles set using resin implementation of 
jstl (they are saved into the pageContext, so we don't need to depend on resin classes)

I'd also like to remove dependencies from the jakarta implementation of jstl but there 
is no other way to obtain a bundle from the parent tag than using
TagSupport.findAncestorWithClass(tag, BundleSupport.class);

So the standard jstl adapter will be compatible with resin but you still need to 
import standard.jar from jakarta. You can get rid of this dependency creating a custom 
adapter and removing the BundleSupport tag lookup.

The fix will be available in tomorrow snapshot builds

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/DISPL-15

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: DISPL-15
    Summary: display-el:column titleKey not Resin compatible
       Type: Bug

     Status: Resolved
   Priority: Major
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: DisplayTag
 Components: 
             I18N
   Fix Fors:
             1.0 RC2
   Versions:
             1.0 RC2

   Assignee: fabrizio giustina
   Reporter: fabrizio giustina

    Created: Sat, 25 Sep 2004 4:43 AM
    Updated: Mon, 11 Oct 2004 8:52 AM

Description:
====
imported from sf tracker
id 996162 
submitted by Steve Swing - sswing
http://sourceforge.net/tracker/index.php?func=detail&group_id=73068&atid=536613&aid=996162
 
====

Resin 2.1.10 & 2.1.14 do not properly work using titleKey
attribute of display-el:column. No ancestor tag that
Resin instantiates extends BundleSupport class that
ELColumnTag imports. Since Resin uses its own
implementations of fmt:Bundle and fmt:SetBundle
neither are found by findAncestorWithClass(this,
BundleSupport.class)

Since ELColumnTag.java imports
org.apache.taglibs.standard.tag.common.fmt.BundleSupp
ort making it require the Jakarta JSTL implementation
standard.jar.

Is it valid for ELColumnTag to use the following instead?

<pre>
public int doStartTag() throws JspException
{
evaluateExpressions();

if (titleKeyExpr != null || parentTitleExpr == null)
{
String key = (titleKeyExpr != null) ?
titleKeyExpr : parentPropertyExpr;
String title =
LocaleSupport.getLocalizedMessage(pageContext, key);
super.setTitle(title != null ? title : titleKeyExpr);
}
return super.doStartTag();
}
</pre>

As a separate issue Resin doesn't appear to make use
of fmt:bundle prefix attribute within calls to
LocaleSupport.getLocalizedMessage() calls.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
displaytag-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to