The following comment has been added to this issue:
Author: fabrizio giustina
Created: Sat, 30 Oct 2004 3:31 PM
Body:
You can attach any needed file here, but first of all please read
http://displaytag.sourceforge.net/issue-tracking.html and consider opening a new item
for each request/enhancement. This and some working junit testcase will give your code
good chances to be committed, while it will probably never be considered if you post
the full source for a such long list of features.
As a first consideration, we should avoid adding an attribute to the table tag for
each enhancement tht could be easily handled in other ways.
> 1: fullListSizeProperty: to handle requirement 1 and 2.
> 2: sortInDatabase: for the requirement 3
the ability to work with incomplete lists is surely a feature displaytag lasks and
wich should be added soon: however I don't think adding these two property could solve
any problem... if the list fetching, sorting and paging is delegated to db or any
other framework the full list size should be handled in the same way (i.e. no
additional attribute specific for the list size)
> 3: exportLinkAtTop: for the requirement 4
there are already some properties for the position of paging banner
(paging.banner.placement) handled by the poperties file or the setProperty tag. This
should be handled in the same way.
> 4: dropdownPageNav: for the the requirement 5
again, this should be handled using properties
> 5: parameterPrefix: for the the requirement 6
parameters are encoded to make paging and sorting work indipendently for tables in the
same page. The ParamEncoder class can be user to obtain parameter names for a specific
table.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/DISPL-89?page=comments#action_25918
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/DISPL-89
Here is an overview of the issue:
---------------------------------------------------------------------
Key: DISPL-89
Summary: Proposal: five additional attributes for display:table
Type: New Feature
Status: Unassigned
Priority: Major
Original Estimate: 2 days
Time Spent: Unknown
Remaining: 2 days
Project: DisplayTag
Components:
Tag Library
Versions:
1.0 RC1
Assignee:
Reporter: Tak Yoshida
Created: Sat, 30 Oct 2004 1:00 PM
Updated: Sat, 30 Oct 2004 3:31 PM
Description:
Hello Matt,
My name is Tak Yoshida.
I have started using displaytag for my new project, where sort, download, and paging
are required.
I was looking forward to use this scince I had your presentation in NY on Apr.
I was so impressed the displaytag's functionalities,
but also found missing functionalities for web application.
To meet these requirements, I would like to propose enhancements for it.
Here are the requirement I could not find in displaytag.
0: assumption is that scope is request.
1: the result collection contains entries only specified in page size,
because it could be too many, so I don't want to construct entire result collection.
(FYI, it's pretty slick to work with SQLMap)
2: the result count cannot be taken from result collection.
3: sort must be done by database, instead of manipulating the result collection.
4: export link should be at the top of the table.
5: page navigatoin must be dropdown list.
6: parameter named should not be encoded for the readability of codes.
I would like to know why this encoded parameter name is necessary?
Here is the proposal.
To add above functions, I would like to introduce five attributes for display:table
tag.
1: fullListSizeProperty: to handle requirement 1 and 2.
2: sortInDatabase: for the requirement 3
3: exportLinkAtTop: for the requirement 4
4: dropdownPageNav: for the the requirement 5
5: parameterPrefix: for the the requirement 6
Based on these additional attributes, the current functions are not infected at all,
and modified code is so simple and very straightforward.
To give you an idea,
Here is the snippet of the jsp,
<display:table name="OrderSearchPage.resultList" class="resulttable"
cellpadding="0" cellspacing="0"
export="true" sort="list"
pagesize= "<%=OrderSearchPage.getPageSize()%>"
requestURI="/orderinquiry/OrderSearchPage/searchOrder.do"
dropdownPageNav="true"
sortInDatabase="true"
fullListSizeProperty="OrderSearchPage.resultCount"
exportLinkAtTop="true"
parameterPrefix="table">
and here is the snapshot of the result.
I would really appreciate it, if you would review and consider attached
patch in your future release.
All the modificaiton start with "// TY start" and end with "// TY end",
and there are 12 places in 4 classes.
Oops, I cannot attch image here.
Please let me know where I can post them.
Thanks for your time to read my proposal,
Tak Yoshida
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
_______________________________________________
displaytag-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/displaytag-devel
