[ http://jira.codehaus.org/browse/DISPL-213?page=comments#action_40460 ]
     
Markus Schmitt commented on DISPL-213:
--------------------------------------

Hello.

I think i found the problem for this issue.

The bug lies in the Class org.displaytag.pagination.SmartListHelper in the 
method getPageNavigationBar(Href baseHref, String pageParameter):
This method generates the navigationbar.
While computing the startPage there is a little mistake:
The line:

startPage = 
 Math.max(Math.min(this.currentPage - groupSize / 2, this.pageCount - 
groupSize),1);

has to be changed to:

startPage = 
 Math.max(Math.min(this.currentPage - groupSize / 2, this.pageCount - groupSize 
+ 1),1);

I tried it and it works fine.

Regards
Markus


> Page Listing Incorrect
> ----------------------
>
>          Key: DISPL-213
>          URL: http://jira.codehaus.org/browse/DISPL-213
>      Project: DisplayTag
>         Type: Bug
>   Components: Paging/Sorting
>     Versions: 1.0
>     Reporter: Peter Luttrell
>     Priority: Critical

>
>
> Depending on the number of results for which DisplayTag is paginating, the 
> last page is often NOT displayed.
> For example if you're paginating 110 results in pages of 10 you should get 11 
> pages, but only 10 show up. You can get to the 11th page by hitting last - 
> it's just not showing up in the list of pages. Another example is 220 
> paginated by 20.
> I have modified example-paging.jsp to show the problem.
> <%@ include file="inc/header.jsp" %>
> <% Object foo = request.getAttribute( "test" );
>    if( foo == null ) {
>       request.setAttribute( "test", new TestList(110, false) );
>    }
> %>
> <h2>Here's a test of 110 in pages of 10</h2>
> <display:table name="requestScope.test" pagesize="10">
>       <display:column property="id" title="ID" />
>       <display:column property="name" />
>       <display:column property="email" />
>       <display:column property="status" />
> </display:table>
> <%@ include file="inc/footer.jsp" %>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to