On 6/2/05, Matt Raible <[EMAIL PROTECTED]> wrote: > So how do I verify coverage? I agree that coverage is good, but we > should probably be more active in JIRA and tell folks that we need a > test in order to commit, rather than just letting the patches sit.
see http://displaytag.sourceforge.net/issue-tracking.html "If you want to see your patch quickly applied by committers, you should be able to provide the following items: 1. A CVS diff against the latest CVS version. No, a zip file with all modified sources is not OK. 2. One or more junit tests related to the new feature. Also, be sure to run all of the existing testcases to verify that you are not breaking existing code. Look in the src/test directory to understand how to write simple JSP test cases. 3. Update the documentation (xdoc files and/or the sample application)" that has always been there... don't know how to make it more evident... I plan to review all the standing items in jira soon and I will comment on items without an appropriate test case. > Also, when I run "maven" from the top, the build fails with the > following error: > mh, don't know from where the findbug error came from, but I still wasn't able to complete the maven multiproject build, so you could experiment some glitches... I am just testing a nightly multiproject build which should upload the results to http://displaytag.sourceforge.net/11 , but as you can see that is still not working. Anyway, you should be able to run your test from your IDE and add a simple test which uses a decorator with that ID addiction, right? fabrizio > > Matt > > > fabrizio > > > > > > > > On 6/2/05, Matt Raible <[EMAIL PROTECTED]> wrote: > > > > > >> I've applied the following patch in JIRA and would like to change its > >> status to "Fixed". However, it doesn't seem that I have permission to > >> do so. > >> > >> http://jira.codehaus.org/browse/DISPL-192 > >> > >> Can someone give me permission? > >> > >> Thanks, > >> > >> Matt > >> > >> > >> ------------------------------------------------------- > >> This SF.Net email is sponsored by Yahoo. > >> Introducing Yahoo! Search Developer Network - Create apps using Yahoo! > >> Search APIs Find out how you can build Yahoo! directly into your own > >> Applications - visit http://developer.yahoo.net/?froffad-ysdn-ostg-q22005 > >> _______________________________________________ > >> displaytag-devel mailing list > >> displaytag-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/displaytag-devel > >> > >> > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by Yahoo. > > Introducing Yahoo! Search Developer Network - Create apps using Yahoo! > > Search APIs Find out how you can build Yahoo! directly into your own > > Applications - visit > > http://developer.yahoo.net/?fr_______________________________________________ > > displaytag-devel mailing list > > displaytag-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/displaytag-devel > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by Yahoo. > Introducing Yahoo! Search Developer Network - Create apps using Yahoo! > Search APIs Find out how you can build Yahoo! directly into your own > Applications - visit http://developer.yahoo.net/?froffad-ysdn-ostg-q22005 > _______________________________________________ > displaytag-devel mailing list > displaytag-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/displaytag-devel > ------------------------------------------------------- This SF.Net email is sponsored by Yahoo. Introducing Yahoo! Search Developer Network - Create apps using Yahoo! Search APIs Find out how you can build Yahoo! directly into your own Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005 _______________________________________________ displaytag-devel mailing list displaytag-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-devel
