[ http://jira.codehaus.org/browse/DISPL-139?page=comments#action_41631 ]
Paul Reader commented on DISPL-139: ----------------------------------- If you're planning on breaking compatibility, I think it would be better to either add a init() / setPageContext() method which is called when the decorator is instantiated, or go back to the original design where the ColumnDecorator was a class instead of an interface, and reinstate the init() method. My only concern with your proposal of adding the page context as a parameter to the decorate method is that it makes one-time initialisation of the decorator messy. Regards Paul > Will ColumnDecorator regain access to the PageContext? > ------------------------------------------------------ > > Key: DISPL-139 > URL: http://jira.codehaus.org/browse/DISPL-139 > Project: DisplayTag > Type: Improvement > Components: Decorators > Versions: 1.0 RC2 > Reporter: Paul Reader > Fix For: 1.1 > > > I'm been on the verge of upgrading from v0.8.5 for several months now. The > one thing holding me back is the fact that the ColumnDescorator no longer has > access to the PageContext as it does in v0.8.5. > Almost all of my column decorators use the ColumnDecorator init() method for > i18n purposes. The addition of the column sortProperty attribute now means I > can use the TableDecorator for the same purpose, but before I discard all my > column decorators, which are really convenient, is there any plan to > reinstate this functionality? > Thanks > Paul > P.S. Sorry if this sounds like I'm moaning. This is a great tag library. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ displaytag-devel mailing list displaytag-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-devel
