[ http://jira.codehaus.org/browse/DISPL-232?page=comments#action_46933 ] 

Stefan Baramov commented on DISPL-232:
--------------------------------------

I've looke the source code from Sep 11 and found the bug is not fixed 
correctly. The original suggestion is correct: this.isLast() ? this.currentPage 
: this.lastPage . The current version is : this.lastPage. It breaks when the 
last page is displayed (then this.lastPage is null).

Please reopen the issue. 

> paging.banner.full: {6} is not the total number of pages
> --------------------------------------------------------
>
>          Key: DISPL-232
>          URL: http://jira.codehaus.org/browse/DISPL-232
>      Project: DisplayTag
>         Type: Bug
>   Components: Configuration
>     Versions: 1.0
>      Fix For: 1.1

>
>
> {6} in the configuration item paging.banner.full does not display the total 
> number of pages (as it should according to the documentation), but the number 
> of page links displayed in the banner.
> Following is the correction for Pagination.java:
>         Object[] pageObjects = {
>             numberedPageString,
>             ((Href) this.href.clone()).addParameter(this.pageParam, 
> getFirst()),
>             ((Href) this.href.clone()).addParameter(this.pageParam, 
> getPrevious()),
>             ((Href) this.href.clone()).addParameter(this.pageParam, 
> getNext()),
>             ((Href) this.href.clone()).addParameter(this.pageParam, 
> getLast()),
>             this.currentPage,
>             /* (MVL) corrected: should be number of pages: new 
> Integer(pages.size()) */ 
>             this.isLast() ? this.currentPage : this.lastPage };

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to