[ http://jira.codehaus.org/browse/DISPL-268?page=comments#action_53880 ] 

Eric Dalquist commented on DISPL-268:
-------------------------------------

The patch I've attached provides full JSR-168 compatibility for the displaytag 
library. The code should work on any JSR-168 compliant container.

I made the following changes to achieve the support.

-Changed the Href class to an interface, moved the existing implementation to a 
class named DefaultHref.
-Removed the DefaultHref(Href) constructor, changed all use of the copy 
constructor to use the Href.clone() method, allowing Hrefs to be cloned 
regardless of the implementation.
-Added the PortletRequestHelperFactory, PortletRequestHelper and PortletHref 
classes. Using these via the 
'factory.requestHelper=org.displaytag.util.PortletRequestHelperFactory' 
property results in portlet URLs being generated for paging.

Direct links still work (falls back on DefaultHref) if the href or url tag 
property is specified.

The portlet API artifact dependency is not included in the patch I attached. A 
dependence on the 
http://www.ibiblio.org/maven/javax.portlet/poms/portlet-api-1.0.pom is required 
for compiling the Portlet* classes. It is not required at run time if these 
classes are not used.

> Add two classes to project to support JSR168 based portlets
> -----------------------------------------------------------
>
>          Key: DISPL-268
>          URL: http://jira.codehaus.org/browse/DISPL-268
>      Project: DisplayTag
>         Type: Improvement

>   Components: Container Compability
>  Attachments: PortletRequestHelper.java, PortletRequestHelperFactory.java, 
> displaytag_portlet.patch
>
>
> I'll include the two classes necessary to make this work.  There are no 
> changes necessary to other source code.  Minor changes will be needed to make 
> this build.
> I've got no easy test cases at this time.   I'll see if I can get one to you 
> before too long.
> Finally, there should probably be a minor doc update so folks know how to set 
> this up.
> ( change to display.properties    )
> factory.requestHelper=org.displaytag.util.PortletRequestHelperFactory

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to