[ http://jira.codehaus.org/browse/DISPL-280?page=comments#action_58159 ] 

Kurt Martinsen commented on DISPL-280:
--------------------------------------

Snapshot displaytag-1.1-20060103.091119-1

This also affects sorting if the sortName integer happens to fall in the range 
of headerCellList.size() - 1. In this case the rows are sorted by Display tag 
even though external sorting is used. This happens in 
org.displaytag.model.TableModel.getSortedColumnHeader.

The actual problem might be in org.displaytag.tags.TableTag.doEndTag line 1198. 
(this.paginatedList == null || this.tableModel.isLocalSort()). When using 
external sorting without implementing the PaginatedList interface, the if 
statement resolves as true and continues on to sorting a paged list.

> Sortable header links fail when using external sorting and an integer as the 
> sortName.
> --------------------------------------------------------------------------------------
>
>          Key: DISPL-280
>          URL: http://jira.codehaus.org/browse/DISPL-280
>      Project: DisplayTag
>         Type: Bug

>   Components: Paging/Sorting
>     Versions: 1.1
>     Reporter: Kurt Martinsen
>      Fix For: 1.1

>
> Original Estimate: 1 day
>         Remaining: 1 day
>
> Snapshot displaytag-1.1-20060103.091119-1
> When using external sorting, if the column property "sortName" is an integer 
> (for example an index in a collection) it is interpreted as Display tag's 
> sortedColumnNumber instead of sortedColumnName. 
> This results in failure of generating the correct header link for the sorted 
> column (CSS style, ascending/descending).
> My quick fix was to simply set the value to both the sortedColumnNumber and 
> the sortedColumnName, when the integer is parsed succesfully. 
> org.displaytag.tags.TableTag.initParameters line 886. 
> (displaytag-1.1-20060103.091119-1)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to