[ http://jira.codehaus.org/browse/DISPL-245?page=comments#action_59832 ] 

Jeff Sheets commented on DISPL-245:
-----------------------------------

Thanks so much for your help so far, Jorge!  Displaytag is great, and these new 
additions will be great too...

For the caption/footer issue:
I had to setup the new export classes for PDF/Excel in my displaytag.properties 
file like this:
export.pdf.class=org.displaytag.export.DefaultPdfExportView
export.excel.class=org.displaytag.export.excel.DefaultHssfExportView
Apparently only these new classes will display the caption/footer?  I didn't 
realize this before...

Secondly, the new classes only work when I remove my Decorator.  So I'm going 
to look into my decorator and see why it fails on the exporting.  My decorator 
works fine for any of the old export classes, but not the new ones that were 
added for the caption/footer.  It throws the previous stack trace with the new 
export classes for RTF, Excel, and PDF.

For the RTF issue:
My setup from before works for RTF when I don't use my Decorator.  There must 
be something that has changed in the new export classes that is different from 
the old for Decorator's.

Jorge, thanks for all of your great help!

> WYSIWYG Exports
> ---------------
>
>          Key: DISPL-245
>          URL: http://jira.codehaus.org/browse/DISPL-245
>      Project: DisplayTag
>         Type: Improvement

>   Components: HTML Generation, Export
>     Versions: 1.1
>      Fix For: 1.1
>  Attachments: displaytagExamplePatch.txt, displaytagExportPoiPatch.txt, 
> displaytagPatch.txt, ico_file_rtf.png
>
>
> Request for enhancements of the export facility
> 1. The default exporters should render the table as close as possible
>    to the rendered HTML.  When typical business users are presented with the
>    displaytag export facility, they usually expect the exported Excel or PDF 
> to
>    look just like the HTML in their browser; they expect a WYSIWYG rendering.
> 2. The export API should encourage reuse of the table-rendering logic
>    employed to render the table in a JSP.  For instance, to render the 
> grouping
>    in my PDF export just as it appears in the HTML, I would have had to
>    re-implement TableTag.groupColumns().  Also, any future changes to the
>    table rendering would not be included in my PDF export.  So, this looked
>    like a job for the Template Method pattern, which also applies nicely to 
> the 
>    decorators, to ensure that the HTML and default export
>    renderings will be in synch.
> 3. Include caption in export.
> 4. Include footer in export.
> 5. Export in RTF format.
> The attached patch implements the above enhancements.
> <a 
> href="http://www.jamesgood.com:8080/displaytag-examples-1.1-SNAPSHOT/example-new-export.jsp";>
> Here's a live example and a more detailed explanation.</a>
> Following are potential additional export enhacements I'm working on.
> 1. Use css table styles as style configuration for Excel, PDF, and RTF 
> exports.
>    If not practical, provide export style config properties.
> 2. Specify Excel formats for columns, e.g., ##.##.
> 3. Include smart linking in Excel, PDF, and RTF exports.
> 4. Export just the current page, a page range, or all data, especially if
>    paging is used.
>    The ui may look like this:
>    Export options: Excel | PDF | RTF | From: [1] To: [1] (default to this 
> page)
>    Export options: Excel | PDF | RTF | From: [1] To: [max] (default to all)
>    Defaults to exporting what's on the page currently.  Default would be
>    configurable through property.
> 6. Set the column width to the max column string value width.
> 7. Exporters should support nested tables.
> 8. Implement font styles in RTF export, e.g., bold face.
> 9. Export in MS Word format using POI.
> Related Jira issues:
> <ol>
> <li>http://jira.codehaus.org/browse/DISPL-194
> <li>http://jira.codehaus.org/browse/DISPL-123
> </ol>
> Unit Tests:
> The main code change this patch supplies is a refactoring of the 
> table-rendering
> code.  As such, the relevant unit test are the existing tests,
> <a 
> href="http://www.jamesgood.com:8080/displaytag-examples-1.1-SNAPSHOT/docs/multiproject/displaytag/junit-report.html";>
> all of which succeeded.</a>
> -Jorge

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to