[ 
http://jira.codehaus.org/browse/DISPL-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_117393
 ] 

Bernhard Mähr commented on DISPL-370:
-------------------------------------

Same problem here. If e.g. a getter for a rendered row-item throws an exception 
all pages with displaytag-tables gets unusable for all users until a 
serverrestart. The suggested fix works here and would also be my suggestion.

cleanUp(); should be removed from TableTag.java:1226 and added to 
TableTag.java:1628.

Bernhard Mähr at opitz-consulting dot de 

> display tag row number object not cleaing up when any exceptions happen, this 
> forcing server restart
> ----------------------------------------------------------------------------------------------------
>
>                 Key: DISPL-370
>                 URL: http://jira.codehaus.org/browse/DISPL-370
>             Project: DisplayTag
>          Issue Type: Bug
>          Components: Paging/Sorting
>    Affects Versions: 1.1
>            Reporter: sen moon
>            Priority: Blocker
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> if any exception happens the row number used by TableTag class is getting 
> increased, and not getting reset. server output as follows, if you see the 
> server output only release mehtod is called and not the cleanup method. after 
> exception, refreshing the page keep on increasing the row number count and 
> ending up with exception. only restarting the server cleaning up the objects 
> and it is working fine there after.
> Suggestion:
> TableTag.release() method should call cleanUp as well.
> Regards,
> Senthil Mohan
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first 
> iteration=false (row number=5928)
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first 
> iteration=false (row number=5928)
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first 
> iteration=false (row number=5928)
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] 
> doAfterBody called - iterating on row 5928
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] 
> doIteration called
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.model.TableModel) - [row] 
> adding row Row[rowNumber=5928,[EMAIL PROTECTED]
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] 
> doIteration() - iterator ended after 5928 rows
> DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] 
> doEndTag called
> DEBUG [2006-06-29 12:36:31,420] (org.apache.commons.beanutils.BeanUtils) - 
> Describing bean: com.elink.Planning.PlanningData
> DEBUG [2006-06-29 12:36:31,421] (org.displaytag.model.TableModel) - [row] 
> sorting full data
> DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - 
> getProperty [noOfCollections] on bean [EMAIL PROTECTED]
> DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - 
> getProperty [noOfCollections] on bean [EMAIL PROTECTED]
> DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - 
> getProperty [noOfCollections] on bean [EMAIL PROTECTED]
> DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - 
> getProperty [noOfCollections] on bean [EMAIL PROTECTED]
> DEBUG [2006-06-29 12:36:31,441] (org.displaytag.tags.TableTag) - [row] 
> release() called

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to