[ http://jira.codehaus.org/browse/DISPL-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_117918 ]
Mike Calmus commented on DISPL-157: ----------------------------------- Part of this most recent patch could cause issues: if (value != null & value.getClass().isArray()) should be rewritten as: if (value != null && value.getClass().isArray()) If value is null, a NullPointerException will be thrown > Allow displaytag in a form > -------------------------- > > Key: DISPL-157 > URL: http://jira.codehaus.org/browse/DISPL-157 > Project: DisplayTag > Issue Type: Improvement > Affects Versions: 1.1 > Reporter: Paul Woodward > Fix For: 1.2 > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > > Basically I would like to be able to make the sort/page links be javascript > calls to a function. This is so that I can incorporate the displaytag in > existing forms/framework I am using without losing information that is kept > on the page. > I can almost achieve this by: > 1. using a custom RequestHelperFactory to create custom RequestHelper that > creates a special type of Href - a JavascriptHref that takes the displaytag > parameter map and passes it to a function to package up in my existing form. > 2. the same RequestHelper to retrieve the displaytag parameters from the > request object where they are being and pass them back to TableTag when > requested. > The only downfall of this plan is gereating the javascript link. > getSortingHref in TableTag (and the similar functions) do: > Href href = new Href(this.basehref); > And hence I lose the functionality of my special JavascriptHref class. > If it was: > Href href = this.basehref.clone(); > or similar my plan would work perfectly. > As far as I can tell, this would be a minimal impact change, just a clone > method in Href and the use of it in TableTag. > Would this be possible? > Apart from this tiny issue I have, it's a truly excellent project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ displaytag-devel mailing list displaytag-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-devel