[ http://jira.codehaus.org/browse/DISPL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_121242 ]
Robert Scholte commented on DISPL-355: -------------------------------------- I suggest another solution this.currentRow = TableFactory.createRow(iteratedObjec, this.rowNumber) Row has one major problem: in includes both the model AND it's (html)rendering. You're always restricted to the table-layout, where for example a div-based table should also be possible. > create a new Row in the TableTag.java via a function call > --------------------------------------------------------- > > Key: DISPL-355 > URL: http://jira.codehaus.org/browse/DISPL-355 > Project: DisplayTag > Issue Type: Improvement > Components: Tag Library > Reporter: Alex Gerasimov > Original Estimate: 5 minutes > Remaining Estimate: 5 minutes > > I suggest to create a new Row in a slightly different way: > Instead of > this.currentRow = new Row(iteratedObject, this.rowNumber) > (this row is repeated twice in the source code) > a new function should be used: > this.currentRow = getNewRow(iteratedObject, this.rowNumber); > public Row getNewRow(Object iteratedObject, int rowNumber) > { > return (new Row(iteratedObject, this.rowNumber)); > } > This way Row class could be extended and used inside TableTag -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ displaytag-devel mailing list displaytag-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-devel