Hello, Cracked it - for posterities sake I had the issue that my sort was not working with a custom comparator - the jsp was as follows:
<display:column class="code" property="code" sortable="true" titleKey="workitem.code" url="/viewWorkItem.html" paramId="id" paramProperty="id" sortProperty="code" comparator="de.mpicbg.db.common.comparator.AlphanumComparator" /> This however was not working, the custom comparator was not even being constructed - never mind used. I dug around a lot and eventually pulled down the displaytag source and dug through it - sprinkling logging throughout the code. What was strange was that the setComparator was not being called, i checked the setdecorator and that was not being called in other cases - but it did work. To cut a long story short, I inherited my includes header which had the following import: <%@ taglib uri="http://displaytag.sf.net/el" prefix="display" %> This meant that the display would _always_ use the el version of the classes no matter what happened and these did not use the setXXX on the model. This is compounded in that there is a slight bug in setComparator on the column class in that this is being evaluated there and then and not in end tag (there is even a todo abut it) - therefore if you evaluate on set but the el version does not use set then you will never manage to set your comparator if you are using the el version of displaytag. I've fixed that bug in my code here - to the devs do you want a patch for the fix? It is not much of a patch (as it requires not much of a fix!) as it is pretty simple to fix but I could submit it if you wish. Cheers, Neil ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ displaytag-user mailing list displaytag-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-user