I modified my original patch by hand, and checked that it applies cleanly, and that the code compiles, and still does the right thing. I've attached my randomization patch to this message.
It stores the remote hosts file in a global now. This isn't strictly necessary for this patch, but in general, if you want to put options in the hosts file, it needs to be parsed earlier. This is also more symmetric with the localhost global that is maintained. Michael -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jean Delvare Sent: Tuesday, March 29, 2005 9:22 AM To: [email protected] Subject: Re: [distcc] Limiting cpp0, randomizing hosts, more verboselocalhost lockfile names Hi Michael, > As mentioned last week, I've put together these changes for submission > to the project. I think I understand that you made several changes, but you provide a single patch. Could you please instead provide indivdual patches, each doing one thing? It will make review and integration much easier. > The other change is to randomize host selection, and choose based on > slots. This means that hosts with 4 available slots are 4 times more > likely to be chosen than a host with only 1 available slot. I am interested in this part. I think there were other attempts to do that, but these were never integrated into distcc. So if you can provide a patch which does only this, I'll review it. > Last, the localhost lock file now includes part of the host name. We > have 4 "localhosts" in use here on shared disks. Without this change, > they all used the same lockfiles. This meant that box 2 would not do > any linking, because box 1 was already doing 4. Why not simply use the hostname instead of localhost? I'd expect it to be more simple, and to work in all cases. Am I missing something? > Local compilation slots can be set without adding localhost to the > hostlist, by setting "-localslots=<num>" With what benefit over using the regular way? Thanks, -- Jean Delvare __ distcc mailing list http://distcc.samba.org/ To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/distcc
patch_2005_03_29.rand
Description: patch_2005_03_29.rand
__ distcc mailing list http://distcc.samba.org/ To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/distcc
