-1 - verified source package, binary package. all md5, sha1 and asc look good. - NOTICE, LICENSE look good - source package can compile. - both source package and binary package: verified tutorial, can run successful with core library.
However, it failed to run tutorial with write proxy. I suspected this is related to ByteBuf changes recently. Sep 11, 2017 7:55:54 AM com.twitter.util.RootMonitor$ handle SEVERE: Exception propagated to the root monitor! java.lang.UnsupportedOperationException at java.nio.ByteBuffer.array(ByteBuffer.java:994) at org.apache.thrift.protocol.TBinaryProtocol.writeBinary(TBinaryProtocol.java:211) at org.apache.distributedlog.thrift.service.DistributedLogService$writeWithContext_args.write(DistributedLogService.java:6327) at org.apache.distributedlog.thrift.service.DistributedLogService$ServiceToClient.writeWithContext(DistributedLogService.java:1225) at org.apache.distributedlog.client.DistributedLogClientImpl$WriteOp.sendWriteRequest(DistributedLogClientImpl.java:428) at org.apache.distributedlog.client.DistributedLogClientImpl$AbstractWriteOp.sendRequest(DistributedLogClientImpl.java:365) at org.apache.distributedlog.client.DistributedLogClientImpl.sendWriteRequest(DistributedLogClientImpl.java:957) at org.apache.distributedlog.client.DistributedLogClientImpl.access$300(DistributedLogClientImpl.java:106) at org.apache.distributedlog.client.DistributedLogClientImpl$StreamOp.doSend(DistributedLogClientImpl.java:201) at org.apache.distributedlog.client.DistributedLogClientImpl$StreamOp.send(DistributedLogClientImpl.java:185) at org.apache.distributedlog.client.DistributedLogClientImpl$4.onSuccess(DistributedLogClientImpl.java:887) at org.apache.distributedlog.client.DistributedLogClientImpl$4.onSuccess(DistributedLogClientImpl.java:879) - KN On Thu, Sep 7, 2017 at 5:04 AM, Jia Zhai <zhaiji...@gmail.com> wrote: > Hi everyone, > > > Please review and vote on the release candidate #1 for the version > 0.5.0, as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > > The complete staging area is available for your review, which includes: > * JIRA release notes [1], > * the official Apache source release to be deployed to dist.apache.org > [2], > * all artifacts to be deployed to the Maven Central Repository [3], > * source code tag "v0.5.0" [4], > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PPMC affirmative votes. > > [1] https://github.com/apache/distributedlog/pull/180 > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/ > distributedlog/0.5.0-rc1/ > [3] https://repository.apache.org/content/repositories/ > orgapachebookkeeper-1013/ > [4] https://github.com/apache/distributedlog/tree/release-0.5.0 > > Thanks, > -Jia >
