zhaijack commented on issue #172: Issue 166: Code cleanup for 0.5.0 release URL: https://github.com/apache/distributedlog/pull/172#issuecomment-326977725 Hi @sijie, Thanks for the work, After add check-style, there is error report: ``` [INFO] There are 8 errors reported by Checkstyle 6.19 with distributedlog/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/bookkeeper/client/BookKeeperAccessor.java:[0] (javadoc) JavadocPackage: Missing package-info.java file. [ERROR] src/main/java/org/apache/bookkeeper/client/BookKeeperAccessor.java:[23] (javadoc) JavadocStyle: First sentence should end with a period. [ERROR] src/main/java/org/apache/bookkeeper/client/LedgerReader.java:[39] (javadoc) JavadocParagraph: Empty line should be followed by <p> tag on the next line. [ERROR] src/main/java/org/apache/bookkeeper/client/LedgerReader.java:[44,25] (naming) ConstantName: Variable 'logger' should be in ALL_CAPS (if it is a constant) or be private (otherwise). [ERROR] src/main/java/org/apache/bookkeeper/client/LedgerReader.java:[46] (javadoc) JavadocType: Missing a Javadoc comment. [ERROR] src/main/java/org/apache/bookkeeper/client/LedgerReader.java:[82,12] (modifier) ModifierOrder: 'public' modifier out of order with the JLS suggestions. [ERROR] src/main/java/org/apache/bookkeeper/client/LedgerReader.java:[105] (sizes) LineLength: Line is longer than 120 characters (found 130). [ERROR] src/main/java/org/apache/bookkeeper/client/LedgerReader.java:[154] (sizes) LineLength: Line is longer than 120 characters (found 125). ``` Would you please help fix them here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
