leighst commented on a change in pull request #175: Issue 160: Introduce backward compatibility testing URL: https://github.com/apache/distributedlog/pull/175#discussion_r137110346
########## File path: tests/backward/src/main/java/org/apache/distributedlog/tests/backward/ReaderTest.java ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.distributedlog.tests.backward; + +import static com.google.common.base.Charsets.UTF_8; +import static com.google.common.base.Preconditions.checkArgument; + +import java.net.URI; +import org.apache.distributedlog.DistributedLogConfiguration; +import org.apache.distributedlog.LogRecord; +import org.apache.distributedlog.api.AsyncLogReader; +import org.apache.distributedlog.api.DistributedLogManager; +import org.apache.distributedlog.api.namespace.Namespace; +import org.apache.distributedlog.api.namespace.NamespaceBuilder; +import org.apache.distributedlog.common.concurrent.FutureUtils; +import org.apache.distributedlog.util.Utils; + +/** + * A test program to read records. + */ +public class ReaderTest { Review comment: this sounds reasonable, the problem is when you introduce new test pipeline with new tools its making things more complicated. its yet another ci job that has to be run and set up in any environment. the tests are already a little flaky and now we're adding some integration tests that can fail in a whole bunch of new ways. this reduces dev productivity over time. if its necessary though then its ok! also, if we have to do this anyway for smoke test/continuous load test, or for users to make testing easier etc. it wouldn't be much added effort why are shaded libraries so hard to manage? how did it work before? it seems like a LOT of code to add just to avoid some pom config, or some checked in uber jars ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
