I've reworked the APIs using all the feedback: - now using basic types (dict + set) to make the code simpler - renamed the classes using the "Distribution" root name - the global functions are also now sys.path-based and there's no more global variable - egg_info -> egginfo - ...
Please comment ! On Tue, Jun 9, 2009 at 12:07 AM, Kevin Teague<[email protected]> wrote: > Glancing over the EggInfo, EggInfoDirectories, and EggInfoDirectory > APIs, it might be interesting if these were able to match with the PEP > 3119 interfaces (http://www.python.org/dev/peps/pep-3119/). > > For example, the EggInfoDirectories has __iter__, append, clear and > remove methods, but the source code comments list them as 'container > APIs'. Technically though, that's an Iterable interface and a partial > implementation of the MutableSequence interface. > > The EggInfoDirectories.get_egg_infos(project_name) is also suggestive > of the Mapping interface - if this method was shortened from > get_egg_infos() to just get(). > > Maybe it would be confusing if an EggInfoDirectories was a > MutableSequence which could only have paths added to it, but returned > an iterable of EggInfoDirectory, but could also be accessed as a > Mapping where the keys are project names and those values are > EggInfos ... but maybe something along those lines would work? > _______________________________________________ > Distutils-SIG maillist - [email protected] > http://mail.python.org/mailman/listinfo/distutils-sig > -- Tarek Ziadé | http://ziade.org _______________________________________________ Distutils-SIG maillist - [email protected] http://mail.python.org/mailman/listinfo/distutils-sig
