At 03:37 PM 5/3/2010 +0200, Manlio Perillo wrote:
Phillip J. Eby ha scritto:
> At 09:35 AM 5/2/2010, Manlio Perillo wrote:
>> Hi.
>>
>> Currently setuptools only support a ``tag-svn-revision`` option.
>> However I use Mercurial, and I would like to tag hg revisions.
>>
>>
> [...]
>>     def tags(self):
>>         version = ''
>>         if self.tag_build:
>>             version+=self.tag_build
>>         if self.tag_revision:
>>             for ep in iter_entry_points(
>>                 'setuptools.tag_revision', self.tag_revision):
>>                 version += '-r%s' % ep.load()()
>>
>>                 # Only use first entry point
>>                 break
>
> This won't work correctly unless you have only one such plugin
> installed, so the feature needs to be explicitly configured for one
> specific plugin.
>

Can you give me more details?
I not sure to understand why it will not work when there is more than
one plugin.
...
> Attach it to this outstanding feature request:
>
> http://bugs.python.org/setuptools/issue42
>
> As you'll see, there's been some previous discussion for this, and I do
> plan to make pluggable revision support available in 0.7.  It will
> probably be similar to the most recent patch attached to that issue,
> with a change to the option name and a few other tweaks.
>

Ok.
The feature is quite similar to what I had in mind.

The only difference I can see is that when a plugin return a non empty
string, the next plugin is checked.

Hm. I thought you were misreading the patch, but then I looked more closely and saw that I was actually misreading *your* patch... and the problem I thought it had does not actually exist. Sorry for the confusion.



_______________________________________________
Distutils-SIG maillist  -  [email protected]
http://mail.python.org/mailman/listinfo/distutils-sig

Reply via email to