On Fri, Feb 5, 2016 at 12:52 PM, Nathaniel Smith <n...@pobox.com> wrote:
> On Feb 5, 2016 9:35 AM, "Nate Coraor" <n...@bx.psu.edu> wrote: > > > > On Sat, Jan 30, 2016 at 3:37 AM, Nathaniel Smith <n...@pobox.com> wrote: > >> > >> On Fri, Jan 29, 2016 at 11:52 PM, Nick Coghlan <ncogh...@gmail.com> > wrote: > >> > On 30 January 2016 at 09:29, Nathaniel Smith <n...@pobox.com> wrote: > >> >> Hi all, > >> >> > >> >> I think this is ready for pronouncement now -- thanks to everyone for > >> >> all their feedback over the last few weeks! > >> >> > >> >> The only change relative to the last posting is that we rewrote the > >> >> section on "Platform detection for installers", to switch to letting > >> >> distributors explicitly control manylinux1 compatibility by means of > a > >> >> _manylinux module. > >> > > >> > In terms of the proposal itself, I think this version is excellent :) > >> > > >> > However, I realised that there's an implicit assumption we've been > >> > making that really should be spelled out explicitly: manylinux1 wheels > >> > targeting CPython 3.2 and earlier need to be compiled against a > >> > CPython built in wide Unicode mode, and in those cases, the detection > >> > of manylinux1 compatibility at the platform level should include > >> > checking for "sys.maxunicode > 0xFFFF". > >> > >> Doh, excellent catch! > >> > >> I've just pushed the obvious update to handle this directly to the > >> copy of the PEP in the manylinux repository. > >> > >> Diff: > https://github.com/manylinux/manylinux/commit/2e49cd16b89e0d6e84a5dc98ddb1a916968b73bc > >> > >> New text in full: > >> > https://raw.githubusercontent.com/manylinux/manylinux/2e49cd16b89e0d6e84a5dc98ddb1a916968b73bc/pep-513.rst > >> > >> I haven't sent to the PEP editors, because they already have another > >> diff from me sitting in their inboxes and I'm not sure how to do this > >> in a way that doesn't confuse things :-) > > > > > > Now that pip and wheel both support the Python 3 SOABI tags on 2.X, is > this necessary? The ABI tag should be set correctly on both the build and > installation systems, so is including it as part of the manylinux1 ABI (and > fixing it to wide builds only) overkill? > > Hah, I just asked the same thing :-). Clearly I should finish scrolling > through my inbox before replying... > Heh, me too. Just replied over on the other thread. > Anyway, I would like to know this as well. :-) > > Also, just to confirm, the new releases of pip and wheel enable this for > 2.x; is it also available for all 3.x? > > -n > ABI tags always worked with wheel/pip on CPython 3.2+ (it has the SOABI config var), the new change "backports" this functionality to 2.X. --nate
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig
