On 29 January 2018 at 19:35, Paul Moore <p.f.mo...@gmail.com> wrote: > On 29 January 2018 at 04:45, Nick Coghlan <ncogh...@gmail.com> wrote: >> On 29 January 2018 at 11:54, Robert Collins <robe...@robertcollins.net> >> wrote: >>> It won't be testable by most developers, if be inclined to say that making >>> the VCS layer a supported plugin point would be a better patch to merge. >>> That would be testable. >> >> Right, I suspect without that, the Perforce support would end up >> intermittently broken, since pre-merge CI wouldn't be able to cover >> it. > > The existing PR does actually include tests that install and verify > Perforce functionality. I don't follow all the details, but the intent > is definitely there - Barney has done a good job with the PR.
If the functionality can be tested in Travis, then I'd say go for it, and don't worry about gating it behind defining a stable plugin API that 3rd party projects can implement. Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia _______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig
