Review: Approve
1. I think this should either be %r or you should mention the type to make 
figuring out what you're *actually* passing a little easier, __str__ can be 
deceiving:

10      + 'Received %s instead of a sequence' % (pathSegments,))

2. Can you assert a little bit more about the exception in 
test_createNewStringPath?

Merge when you're happy with those.
-- 
https://code.launchpad.net/~divmod-dev/divmod.org/829872-createnew-type-check/+merge/72277
Your team Divmod-dev is subscribed to branch 
lp:~divmod-dev/divmod.org/829869-explicit-type-dropping.

-- 
Mailing list: https://launchpad.net/~divmod-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~divmod-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to