Review: Needs Fixing > list(plugin.getPlugins(plugin.IPlugin, "axiom.plugins"))
I haven't actually tried running this code yet, but I'm pretty sure it raises an exception. The second parameter to getPlugins() is an actual python module object, not a string. In other words, this code should be something like: import axiom.plugins list(plugin.getPlugins(plugin.IPlugin)) list(plugin.getPlugins(plugin.IPlugin, axiom.plugins)) (Note the two calls to getPlugins; we want to regenerate the cache for twisted.plugins as well as for axiom.plugins) Alas, I suspect this approach may work fine when running 'setup.py install' as the old setup.py did, but fail during a pip installation (or during the building of a Debian/etc. package) as Axiom is not being installed into a location that is on the sys.path of the running Python interpreter. -- https://code.launchpad.net/~lvh/divmod.org/modernize-axiom-packaging/+merge/180311 Your team Divmod-dev is subscribed to branch lp:divmod.org. -- Mailing list: https://launchpad.net/~divmod-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~divmod-dev More help : https://help.launchpad.net/ListHelp
