Hello Fabrice, given that the tests there are very basics, we do not weight the codecov report as a no go for not merging the PR. If we see that you submitted a test alongside the PR, it's almost certain that it's gonna get merged.
Eventually also ping Paulo again for review and merge. Cheers Angelo On Sunday, 24 September 2017 11:41:40 UTC+2, Fabrice Pardo wrote: > > Hi, > > After submitting pull request > https://github.com/divio/djangocms-snippet/pull/45, > codecov/patch is complaining about 50% of diff hit (target 65.05%). > > The problem is that render method was not covered before patch: > > https://codecov.io/gh/divio/djangocms-snippet/src/master/djangocms_snippet/cms_plugins.py#L23 > > Now the pull request is marked with an infamous red cross, even it is (in > my opinion) a not so bad pull request. > > Is this red cross not so infamous, or is the travis/codecov configuration > too strict? > > -- > Fabrice > > > -- Message URL: https://groups.google.com/d/msg/django-cms-developers/topic-id/message-id Unsubscribe: send a message to [email protected] --- You received this message because you are subscribed to the Google Groups "django CMS developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/django-cms-developers/bc00b7fa-f582-4e7e-a764-e83059e8d2bb%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
