On 30/05/11 10:15, Jannis Leidel wrote: > Hi all, > > Stephan and me are now happy with the latest patch for ticket #9200 > which refactors the form wizard in the formtools contrib app to > use class based views and the new secure cookies as one of the > supported storage backends (a session backend being the other). > > https://code.djangoproject.com/attachment/ticket/9200/ticket9200-2.diff > > I plan to commit this patch this week so please speak up now if > you find any problems with the API or docs. > > Thanks, > Jannis > > PS: The code can also be found here: > https://github.com/jezdez/django/tree/feature/formwizard >
A few points I noticed, without having done a real review of the working code: * we need something in release notes and deprecation timeline about the deprecation of the old FormWizard. And presumably some noise about the new feature in the release notes * if you are adding a warning filter for the old FormWizard in django/contrib/formtools/tests/__init__.py, I'm guessing there should be one in tests/regressiontests/formwizard/tests.py as well. Or, you could perhaps nuke the latter tests - I believe there is large overlap, and I think one set was added without knowledge of the other. Regards, Luke -- "The truth will set your teeth free." (Calvin and Hobbes) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
