Hi Özgür, I'm not sure if you saw it or not but I did come up with a solution in another branch (https://github.com/epicserve/drf-validation-issue/blob/fix-validation/pizzas/serializers.py) and I did end up overriding *run_validation* and *to_internal_value*. If I can find time, I think I'll look into putting my solution into a fork of DRF and just see what might break when I run tests. It doesn't seem like anything would break, but I'm not confident that is the case.
On Wednesday, July 1, 2020 at 6:02:53 AM UTC-5, Özgür Akçalı wrote: > > I think you also need to override *run_validators *method in your example > project for it to work as you expect, just like you did for > *to_internal_value. > *If a validation error is raised fom run_validators method, *validate *method > is not called, so you can not aggregate any possible errors raised from > validation checks in that method. > > Also, with this flow, you should take care not to raise validation errors > in your custom *validate *methods one by one, but aggregate them and > raise them or return them together there as well. > > On Wednesday, July 1, 2020 at 1:45:00 PM UTC+3, Özgür Akçalı wrote: >> >> Though you can not achieve what you want by just overriding *validate, *and >> not overriding *run_validation*. >> >> This would be a major change in DRF though, as with the current behavior, >> when you write your *validate *method, you can assume other validations >> passed, so I imagine changing this behavior as default now would break a >> lot of existing code. I think this would fit better as an optional >> addition, maybe with a configuration option on existing serializer classes, >> or with a different set of serializer classes. >> >> On Wednesday, July 1, 2020 at 1:59:33 AM UTC+3, Brent O'Connor wrote: >>> >>> I guess my point is that I don't feel like I should have to override >>> anything and this should be DRF's default behavior. 🙂 Thank you for >>> pointing out that `validation` should be the method that should be used. >>> >>> On Tue, Jun 30, 2020, 5:42 PM Carl Nobile <carl....@gmail.com> wrote: >>> >>>> Brent, overriding the 'to_internal_value' method is normal and >>>> encouraged, however, the 'run_validation' shouldn't generally be >>>> overridden, what you can override is the 'validate' method which is called >>>> by 'run_validation'. >>>> ~Carl >>>> >>>> On Tue, Jun 30, 2020 at 5:51 PM Brent O'Connor <epic...@gmail.com> >>>> wrote: >>>> >>>>> For anyone that might come across this thread, I went ahead and >>>>> created an issue >>>>> <https://github.com/encode/django-rest-framework/issues/7394> for >>>>> this on Github. >>>>> >>>>> On Friday, June 26, 2020 at 5:08:03 PM UTC-5, Brent O'Connor wrote: >>>>>> >>>>>> I created an example project >>>>>> <https://github.com/epicserve/drf-validation-issue> to illustrate >>>>>> this issue, but basically if you have custom validation logic on a >>>>>> serializer and the data has a field that isn't valid, then the errors >>>>>> raised are only the field level errors and not the custom validation >>>>>> logic >>>>>> errors. This ends up being a bad user experience because the user can >>>>>> fix >>>>>> the field error and then when post another request they can end up >>>>>> getting >>>>>> errors thrown in the custom validation. I'm thinking this might need to >>>>>> be >>>>>> an issue added the DRF project on Github, but thought I would check here >>>>>> first. Please see the project example for more details. >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Django REST framework" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to django-rest-framework+unsubscr...@googlegroups.com. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/django-rest-framework/ea8a9b5d-a671-42b4-9cee-043f28f8efa3o%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/django-rest-framework/ea8a9b5d-a671-42b4-9cee-043f28f8efa3o%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> >>>> >>>> -- >>>> >>>> ------------------------------------------------------------------------------- >>>> Carl J. Nobile (Software Engineer) >>>> carl....@gmail.com >>>> >>>> ------------------------------------------------------------------------------- >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Django REST framework" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to django-rest-framework+unsubscr...@googlegroups.com. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/django-rest-framework/CAGQqDQL2UvWyjr6UgK%2BpCDexAc%2BC%2BeBUGxAwZYyaxC3dJYwGsQ%40mail.gmail.com >>>> >>>> <https://groups.google.com/d/msgid/django-rest-framework/CAGQqDQL2UvWyjr6UgK%2BpCDexAc%2BC%2BeBUGxAwZYyaxC3dJYwGsQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- You received this message because you are subscribed to the Google Groups "Django REST framework" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-rest-framework+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-rest-framework/5035a940-012e-4c06-bc73-1fe8940e6476o%40googlegroups.com.
