#2413: FileField edit_inline broken
-----------------------------+----------------------------------------------
Reporter: Gacha | Owner: adrian
Type: defect | Status: reopened
Priority: highest | Milestone:
Component: Admin interface | Version: SVN
Severity: critical | Resolution:
Keywords: |
-----------------------------+----------------------------------------------
Comment (by [EMAIL PROTECTED]):
Joel -- I wish I had seen this before I submitted ticket #2534 -- There is
a big problem right now, with all_cores_given and all_cores_blank both
being possible. As far as I can tell, it can only happen when !FileFields
are the '''only''' core fields in the model. If it happens, you get
effects like files being uploaded and then immediately deleted, or three
records being created the first time you save the model, and then all
deleted the next time, with one new one being created. Odd stuff, but all
generally traceable back to this bit of code.
The patch that I have uploaded for #2534 overlaps yours a bit; it
specifically makes !FileFields deletable, by adding a checkbox to their
manipulator form field, and does away with the logic that treats them as
special cases.
Also, instead of adding a get_manipulator_new_file_data method, I fixed
the get_manipulator_new_data method for !FileFields specifically, thinking
that get_manipulator_new_data should ''always'' return the value that the
field will have, if it is saved, regardless of the type of field. That
alone eliminates a lot of special-case logic.
Perhaps the two tickets (and code) should be merged?
--
Ticket URL: <http://code.djangoproject.com/ticket/2413>
Django <http://code.djangoproject.org/>
The web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates
-~----------~----~----~----~------~----~------~--~---
