#3297: newforms: Implement FileField and ImageField
---------------------------------------+------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: adrian
Status: reopened | Component: django.newforms
Version: SVN | Resolution:
Keywords: newforms | Stage: Accepted
Has_patch: 1 | Needs_docs: 0
Needs_tests: 1 | Needs_better_patch: 0
---------------------------------------+------------------------------------
Changes (by Marc Fargas <[EMAIL PROTECTED]>):
* needs_better_patch: 1 => 0
* stage: Unreviewed => Accepted
Comment:
Hi anonymous, the state "Accepted" should be left as is, it means "This
has to be worked out and fixed". It should move then to "Ready for check-
in" or be closed as invalid. If you look at
[http://www.djangoproject.com/documentation/contributing/#ticket-triage
this diagram] you'll see there's no way back to Unreviwed!!
About the patch, if you are using a SVN checkout, simply run "svn diff >
my_own_patch.patch" or "svn diff <your modified files> >
my_own_patch.patch" that should leave you with a "my_own_patch.patch" file
which contains the differences between your local copy and your current
revision number. So please do 'svn up' before anything.
ALSO, make sure your patch '''applies''' to trunk! If not, leave a patch
for trunk and if you like, another for newforms-admin. But make sure you
don't brake patches for trunk, after all, unless otherwise specified a
patch is to be applied to trunk.
PS: Removed the "patch needs improvement" as the patch on trunk applies
fine, someone will have to deal with the conflict (adrian?) on newforms-
admin if it gets checked-in, or it will need to be improved if adrian
merges his branch before this ticket gets in.
--
Ticket URL: <http://code.djangoproject.com/ticket/3297#comment:17>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
