#3437: djang.http.HttpResponse logic for _is_string is invalid
--------------------------------------------------+-------------------------
Reporter: Brian Harring <[EMAIL PROTECTED]> | Owner:
adrian
Status: new | Component: Core
framework
Version: SVN | Resolution:
Keywords: | Stage:
Unreviewed
Has_patch: 0 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
--------------------------------------------------+-------------------------
Old description:
> code currently does effectively thus-
> if hasattr(content, '__iter__'):
> self._is_string = False
> self._container = content
> else:
> self._is_string = True
> self._container = [content]
>
> Problem is that string objects support iteration.
>
> Fix for it's simple; just do
>
> if not isinstance(content, basestring) and hasattr(content, '__iter__'):
>
> (yes y'all prefer seperate patches, but it's a one liner ;)
New description:
code currently does effectively thus-
{{{
#!python
if hasattr(content, '__iter__'):
self._is_string = False
self._container = content
else:
self._is_string = True
self._container = [content]
}}}
Problem is that string objects support iteration.
Fix for it's simple; just do
{{{
#!python
if not isinstance(content, basestring) and hasattr(content, '__iter__'):
}}}
(yes y'all prefer seperate patches, but it's a one liner ;)
Comment (by adrian):
(Fixed formatting in description)
--
Ticket URL: <http://code.djangoproject.com/ticket/3437#comment:2>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
