#3400: [patch] Support for lookup separator with list_filter admin option
--------------------------------+-------------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: adrian
Status: new | Component: Admin interface
Version: SVN | Resolution:
Keywords: list_filter | Stage: Accepted
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 1
--------------------------------+-------------------------------------------
Changes (by mtredinnick):
* needs_better_patch: 0 => 1
* stage: Design decision needed => Accepted
Comment:
I think it's worth getting this right. You probably aren't the only person
wanting this functionality.
A couple of comments on the patch:
1. please create the diff from the top of the Django source tree. I had
to guess a lot to work out that it was to be applied to
{{{django/contrib/admin/views/main.py}}} (which I think is right). Having
the full path from the tree root to the patched file is helpful.
2. If the {{{FakeForeignKey}}} class has any visibility outside of that
function (which I'm not sure about), it shouldn't be declared inside the
function. In fact, I'm not really thrilled with declaring it inside the
function in the first place, so probably best to move it out to the top-
level of the file. I realise you are trying to avoid namespace pollution,
but it's not worth the sacrifice of clarity to me.
--
Ticket URL: <http://code.djangoproject.com/ticket/3400#comment:3>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
