#2507: [patch] LDAPBackend in django/contrib/auth/backends.py
--------------------------------+-------------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: adrian
Status: new | Component: Contrib apps
Version: | Resolution:
Keywords: | Stage: Accepted
Has_patch: 1 | Needs_docs: 1
Needs_tests: 0 | Needs_better_patch: 1
--------------------------------+-------------------------------------------
Comment (by Marc Fargas <[EMAIL PROTECTED]>):
Replying to [comment:9 Scott Paul Robertson <[EMAIL PROTECTED]>]:
> Works out of the box with my OpenLDAP setup. I didn't need to change any
settings.
Nice to know!!
> Also, why are the calls to the ldap module always done as self.ldap? It
works either way, and removing the self would be cleaner code in my
opinion.
import ldap was inside the class when I took the patch, so I left it
there. I think there would be no problem to move the import to the top of
the file and then s/self.ldap/ldap/ ;)
> Do we want to create the contrib directory? auth is already a contrib
and it seems a bit excessive to have a contrib in contrib, but that just
might be me.
Auth is in contrib, but "contributed authentication backends" seem as
"contribs to auth", or "contribs to the auth contrib" hence the
subdirectory.
> It does seem that the documentation should be in a subdirectory. Maybe
we can just write it up in the current authentication page for now.
It would mess the page a bit, we should try to do things fine from the
start, sure somebody (willison?) will work on an OpenID backend and having
the structure for those contribs (where to place the .py and the .txt)
would be nice. And LDAP is a really speciffic matter, it should not go
with the "generic" authentication documentation (I think).
> I'm all for a LDAP_ATTR_MAP, it seems like a much cleaner method, and
should be easy to maintain current functionality.
I'm a bit busy now but I'll go for it ASAP :)
> Group membership isn't the same between AD and OpenLDAP. OpenLDAP has
group objects with have lists of users. We should go for a base
LDAPBackend (which doesn't bother with groups), and subclass it for AD and
OpenLDAP.
AD has the "members" inside the group objects and users have "memberOf",
in OpenLDAP how do you know which groups a user is member of? with a
search?
> Looks good, thanks for the work, Scott
you're welcome.
Maybe we can bring discussion to django-developers about where to place
the docs and the .py itself :)
--
Ticket URL: <http://code.djangoproject.com/ticket/2507#comment:10>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
