#2160: Can't use value of 0 for primary key
-------------------------------------------+--------------------------------
Reporter: fgutierrez AT aureal.com.pe | Owner: adrian
Status: reopened | Component: Database
wrapper
Version: SVN | Resolution:
Keywords: | Stage: Design
decision needed
Has_patch: 1 | Needs_docs: 0
Needs_tests: 1 | Needs_better_patch: 1
-------------------------------------------+--------------------------------
Comment (by russellm):
``pk is None or pk == ''`` is the right solution in the short term, but in
the slightly-longer-than-short term (i.e., when newforms is rolled out as
the default), I'm not so sure.
The larger design issue is 'should models autoconvert string arguments
into value arguments'. The current behaviour uses ``to_python`` method on
model fields to convert strings into field values, with the side effect
being that in-code instance definitions can also use strings. This
conversion is migrating into the newforms fields. To me, this means that
accepting strings as model values (which the model then converts) is
behaviour that shouldn't be encouraged, which is what the ``pk==''`` case
is protecting (i.e., empty string as form-compliant null).
--
Ticket URL: <http://code.djangoproject.com/ticket/2160#comment:11>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
