#3536: setup.py is broken in (at least) r4549 on (at least) Win32
-------------------------+--------------------------------------------------
   Reporter:  anonymous  |                Owner:  jacob            
     Status:  reopened   |            Component:  Uncategorized    
    Version:  SVN        |           Resolution:                   
   Keywords:             |                Stage:  Ready for checkin
  Has_patch:  0          |           Needs_docs:  0                
Needs_tests:  1          |   Needs_better_patch:  0                
-------------------------+--------------------------------------------------
Changes (by tsal <[EMAIL PROTECTED]>):

  * needs_tests:  0 => 1
  * stage:  Accepted => Ready for checkin

Comment:

 Confirmed that removal of the hack works under Python 2.4.4 on Win32, the
 dist builds, and successfully installs a working version of Django.
 
 I can't seem to attach files, and there really isn't a point in making a
 unified diff when we know where the code is! :)
 
 Basically, the whole hack can be removed.
 
 For those diff-hungry, here's a patch:
 
 {{{
 Index: setup.py
 ===================================================================
 --- setup.py    (revision 4637)
 +++ setup.py    (working copy)
 @@ -26,12 +26,6 @@
      else:
          data_files.append([dirpath, [os.path.join(dirpath, f) for f in
 filenames]])
 
 -# Small hack for working with bdist_wininst.
 -# See http://mail.python.org/pipermail/distutils-sig/2004-
 August/004134.html
 -if len(sys.argv) > 1 and sys.argv[1] == 'bdist_wininst':
 -    for file_info in data_files:
 -        file_info[0] = '/PURELIB/%s' % file_info[0]
 -
  # Dynamically calculate the version based on django.VERSION.
  version = "%d.%d-%s" % (__import__('django').VERSION)
 }}}

-- 
Ticket URL: <http://code.djangoproject.com/ticket/3536#comment:7>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to